Address @elastic/eui/require-table-caption lint violations across @elastic/actionable-obs-team files#250682
Address @elastic/eui/require-table-caption lint violations across @elastic/actionable-obs-team files#250682alexwizp merged 13 commits intoelastic:mainfrom
@elastic/actionable-obs-team files#250682Conversation
…astic/elastic/obs-ux-management-team files
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
# Conflicts: # x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/certificates/certificates.test.tsx # x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/certificates/certificates_list.tsx # x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/pages/certificates.test.tsx
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
…synthetics/components/monitors_page/overview/overview/compact_view/components/monitors_table.tsx Co-authored-by: Miguel Martín <miguel.martin@elastic.co>
…time/components/overview/monitor_list/monitor_list.tsx Co-authored-by: Miguel Martín <miguel.martin@elastic.co>
miguelmartin-elastic
left a comment
There was a problem hiding this comment.
lgtm. Thanks for applying the changes :)
|
Starting backport for target branches: 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/21981688830 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…lastic/actionable-obs-team` files (elastic#250682) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/require-table-caption`. This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a `tableCaption` prop for accessibility. ## Changes 1. 🎯 Added missing `tableCaption` attributes to elements flagged by `@elastic/eui/require-table-caption` — accessibility leveled up! ## Related - elastic/eui#9168 This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team! --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Miguel Martín <miguel.martin@elastic.co> (cherry picked from commit 29698cf) # Conflicts: # x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/certificates/certificates_list.tsx
…lastic/actionable-obs-team` files (elastic#250682) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/require-table-caption`. This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a `tableCaption` prop for accessibility. ## Changes 1. 🎯 Added missing `tableCaption` attributes to elements flagged by `@elastic/eui/require-table-caption` — accessibility leveled up! ## Related - elastic/eui#9168 This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team! --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Miguel Martín <miguel.martin@elastic.co> (cherry picked from commit 29698cf) # Conflicts: # x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/certificates/certificates_list.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ss `@elastic/actionable-obs-team` files (#250682) (#253026) # Backport This will backport the following commits from `main` to `9.3`: - [Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)](#250682) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-02-13T09:28:05Z","message":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Miguel Martín <miguel.martin@elastic.co>","sha":"29698cfcb53529ff4e63f483df1a06d8c9ceaf15","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.4.0","Team:obs-presentation","Team:obs-ux-management","v9.2.5","v9.3.1"],"title":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files","number":250682,"url":"https://github.com/elastic/kibana/pull/250682","mergeCommit":{"message":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Miguel Martín <miguel.martin@elastic.co>","sha":"29698cfcb53529ff4e63f483df1a06d8c9ceaf15"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/250682","number":250682,"mergeCommit":{"message":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Miguel Martín <miguel.martin@elastic.co>","sha":"29698cfcb53529ff4e63f483df1a06d8c9ceaf15"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…ss `@elastic/actionable-obs-team` files (#250682) (#253027) # Backport This will backport the following commits from `main` to `9.2`: - [Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)](#250682) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-02-13T09:28:05Z","message":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Miguel Martín <miguel.martin@elastic.co>","sha":"29698cfcb53529ff4e63f483df1a06d8c9ceaf15","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.4.0","Team:obs-presentation","Team:obs-ux-management","v9.2.5","v9.3.1"],"title":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files","number":250682,"url":"https://github.com/elastic/kibana/pull/250682","mergeCommit":{"message":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Miguel Martín <miguel.martin@elastic.co>","sha":"29698cfcb53529ff4e63f483df1a06d8c9ceaf15"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/250682","number":250682,"mergeCommit":{"message":"Address @elastic/eui/require-table-caption lint violations across `@elastic/actionable-obs-team` files (#250682)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Miguel Martín <miguel.martin@elastic.co>","sha":"29698cfcb53529ff4e63f483df1a06d8c9ceaf15"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Caution
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/require-table-caption.This rule ensure
EuiInMemoryTable,EuiBasicTablehave atableCaptionprop for accessibility.Changes
tableCaptionattributes to elements flagged by@elastic/eui/require-table-caption— accessibility leveled up!Related
@elastic/eslint-plugin-eui] added newrequire-table-captionrule. eui#9168This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team!